Re: [Xen-devel] [PATCH 2/2] xen/trace: Turn the stub debugtrace_{dump, printk}() macros into functions

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.09.16 at 12:00, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 02/09/16 08:57, Jan Beulich wrote:
>>>>> On 01.09.16 at 21:21, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> --- a/xen/include/xen/lib.h
>>> +++ b/xen/include/xen/lib.h
>>> @@ -68,8 +68,10 @@ extern void debugtrace_dump(void);
>>>  extern void debugtrace_printk(const char *fmt, ...)
>>>      __attribute__ ((format (printf, 1, 2)));
>>>  #else
>>> -#define debugtrace_dump()          ((void)0)
>>> -#define debugtrace_printk(_f, ...) ((void)0)
>>> +static inline void debugtrace_dump(void) {};
>>> +static inline void
>>> + __attribute__ ((format (printf, 1, 2)))
>>> +debugtrace_printk(const char *fmt, ...) {};
>>>  #endif
>> With the stray semicolons dropped
> 
> Oh yes of course.
> 
>> and provided this (at least a little surprisingly) doesn't cause any other 
>> fallout with
>> DEBUG_TRACE_DUMP defined,
> 
> I don't know what you mean by this.  We strictly only change the
> non-defined case,

Oh, sorry.

> and that compiles fine on all architectures.

Good.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel