Re: [Xen-devel] [PATCH 1/4] arm: acpi/boot.c is only used during initialisation

[Julien Grall <julien.grall@xxxxxxx>]

On 31/08/16 14:45, Wei Liu wrote:
> On Wed, Aug 31, 2016 at 02:25:59PM +0100, Julien Grall wrote:
> > Hi Wei,
> >
> > On 30/08/16 13:01, Wei Liu wrote:
> > > That file should contain code and data used during initialisation only.
> > >
> > > Mark it as such in build system and correctly annotate enabled_cpus.
> > > This is required to enable gcov support on ARM.
> > I am not sure to understand the requirement here. Does it mean it is not
> > possible to have a mix of init code and runtime code?
> No. That's still allowed.
>
> "This is required to enable gcov support on ARM" is remnant that should
> be deleted, because strictly speaking if we don't change boot.o to
> boot.init.o, the resulting binary should still work.
>
> Please consider this patch a general cleanup.
I had a similar clean up in my todo list :).

> Can I keep your RoB?
Sure.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel