Re: [Xen-devel] [Minios-devel] [PATCH 2/3] mini-os: provide irq on/off/save/restore functions for Mini-OS apps

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Juergen Gross, on Tue 30 Aug 2016 16:08:45 +0200, wrote:
> On 30/08/16 15:54, Wei Liu wrote:
> > On Tue, Aug 30, 2016 at 01:51:22PM +0200, Juergen Gross wrote:
> >> Provide non-inline variants of the local_irq_*() functions for Mini-OS
> >> apps which should not depend on Mini-OS configuration.
> >>
> > 
> > I think it would be worth pointing out which apps need to access such
> > low level functionalities in commit message.
> 
> I stumbled over it with ioemu-stubdom. Basically it could be any app
> using e.g. wake_up() or wait_event() as those are macros fiddling with
> irq on/off. xenevtchn_pending() is another candidate.

I was thinking that we should perhaps rather make wake_up/wait_event
non-inlined, instead of exposing irq on/off.  But then I see that
it's typically used in event handlers too (e.g. *front/back.c), and
applications may want to implement some such...

> >> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > 
> > Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel