Re: [Xen-devel] [OSSTEST PATCH 0/7] Apropos of XTF: Improve failed step selection

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Aug 11, 2016 at 05:17:56PM +0100, Ian Jackson wrote:
> Running XTF in osstest is likely to produce failures where multiple
> steps fail interestingly.  We would like to prefer to report, and
> bisect, earlier steps.
> 
> This series does that.
> 
> Wei, NB, this has a conflict with the XTF pre series that you have
> taken over.  The conflict is not trivial, but easy.  The conflicting
> patch is:
>   Executive: Previous duration estimator: use overall time, not sum of steps
> 

The rebased patch is as followed, please check.

---8<---
From bbdc727965b4d4280bac670823f013d078a54b93 Mon Sep 17 00:00:00 2001
From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Date: Fri, 8 Jul 2016 19:30:58 +0100
Subject: [OSSTEST PATCH] Executive: Previous duration estimator: use overall
 time, not sum of steps
Cc: ian.jackson@xxxxxxxxxxxxx

Some jobs runs steps in parallel.  Do not add up all the insividual
step durations.  Instead, calculate the duration as the time between
first step start and last step finish.

Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
[ wei: rebase and fix conflict ]
Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
---
 Osstest/Executive.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
index 7e31b35..2187a73 100644
--- a/Osstest/Executive.pm
+++ b/Osstest/Executive.pm
@@ -1068,7 +1068,7 @@ END
               FROM steps
              WHERE flight=? AND job=?
         )
-            SELECT sum(finished-started)
+            SELECT sum(max(finished)-min(started))
                 AS duration
               FROM tsteps
              WHERE step != 'ts-hosts-allocate'
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel