Re: [Xen-devel] [PATCH] memory: fix compat handling of XENMEM_access_op

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.08.16 at 11:46, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> On 08/30/2016 12:15 PM, Jan Beulich wrote:
>> Within compat_memory_op() this needs to be placed in the first switch()
>> statement, or it ends up being dead code (as that first switch() has a
>> default case chaining to compat_arch_memory_op()).
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> Compile tested only.
> 
> Looks good to me, and I can try to actually test the code if there's a
> way to do it without having to install a 32-bit dom0.
> 
> Is there a hypervisor command line argument that can help with testing?

I'm afraid this can only be tested by invoking the operation from a
32-bit domain. I don't think that you'd need a Dom0 for that though:
For a DomU, error codes should differ between old and new code
(-ENOSYS vs -EINVAL afaics).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel