Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 24/08/16 09:55, Jan Beulich wrote:
> > > > On 24.08.16 at 04:22, <konrad.wilk@xxxxxxxxxx> wrote:
> > --- a/xen/common/livepatch.c
> > +++ b/xen/common/livepatch.c
> > @@ -70,6 +70,9 @@ struct payload {
> >       unsigned int nsyms;                  /* Nr of entries in .strtab and 
> > symbols. */
> >       struct livepatch_build_id id;        /* ELFNOTE_DESC(.note.gnu.build-id) 
> > of the payload. */
> >       struct livepatch_build_id dep;       /* ELFNOTE_DESC(.livepatch.depends). 
> > */
> > +    void **bss;                          /* .bss's of the payload. */
> > +    size_t *bss_size;                    /* and their sizes. */
> Is size_t wide enough in the extreme case? Perhaps yes, because I
> don't think we'll ever load 64-bit ELF on a 32-bit platform.
Even if we did, there is no chance that more than a single size_t's 
worth of data needs clearing, or the payload wouldn't fit in the current 
virtual address space.
~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel