Re: [Xen-devel] [PATCH v2 13/20] livepatch: Initial ARM64 support.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.08.16 at 15:37, <konrad.wilk@xxxxxxxxxx> wrote:
> --- a/xen/include/xen/types.h
> +++ b/xen/include/xen/types.h
> @@ -14,6 +14,12 @@
>  #define NULL ((void*)0)
>  #endif
>  
> +#define U16_MAX         ((u16)~0U)
> +#define S16_MAX         ((s16)(U16_MAX>>1))
> +#define S16_MIN         ((s16)(-S16_MAX - 1))
> +#define U32_MAX         ((u32)~0U)
> +#define S32_MAX         ((s32)(U32_MAX>>1))
> +#define S32_MIN         ((s32)(-S32_MAX - 1))

These are rather strange constants: Fixed width types necessarily
always have the same boundaries of representable values. Otoh
the C standard has such constants too - maybe if we really want
them we should rather use their names?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel