[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] mkelf32 incorrectly filling out the program headers for NOTE



>>> On 24.08.16 at 12:07, <s.munaut@xxxxxxxxxxxxxxxxxxxx> wrote:
> Hi,
> 
> Here's the readelf output (snipped) on a xen-4.7 build :
> 
> Section Headers:
>   [Nr] Name              Type            Addr     Off    Size   ES Flg Lk 
> Inf Al
>   [ 0]                   NULL            00000000 000000 000000 00      0   
> 0  0
>   [ 1] .text             PROGBITS        00100000 000080 1d0220 00 WAX  0   
> 0 64
>   [ 2] .shstrtab         STRTAB          00000000 1d0340 000018 00      0   
> 0  1
>   [ 3] .note             NOTE            00168e58 168ed8 000024 00      0   
> 0  4
> 
> Program Headers:
>   Type           Offset   VirtAddr   PhysAddr   FileSiz MemSiz  Flg Align
>   LOAD           0x000080 0x00100000 0x00100000 0x1d0220 0x216000 RWE 0x40
>   NOTE           0x168e58 0x00168e58 0x00168e58 0x00024 0x00024 R   0x4
> 
> If you look at the "offset" value for the .note section and the NOTE
> program headers, they don't match ... but both should represent an
> offset inside the file image and to the same thing, so they should
> match.
> 
> The correct one is the one of the .note and the incorrect value of the
> program header one causes kexec to parse the header wrongly and just
> plain crash. (granted it should be more robust and not segfault, but
> still)

Indeed, patch in the works. But why did you not provide a patch
yourself, considering that you've done all the diagnosis?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.