Re: [Xen-devel] [PATCH v1 9/9] livepatch: tests: Make them compile under ARM64

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

> > > @@ -24,7 +27,9 @@ const char *xen_hello_world(void)
> > >       */
> > >      rc = __get_user(tmp, non_canonical_addr);
> > >      BUG_ON(rc != -EFAULT);
> > > -
> > > +#else
> > > +     asm(ALTERNATIVE("nop", "nop", 1));
> > 
> > Why the hardcoded 1 here? I am wondering if we should introduce a new
> > capability "LIVEPATCH_TEST" which is enabled by default. So we can test that
> > the the alternative is working on all the platform. What do you think?
> 
> Sure, but I am not sure what number you would like? Perhaps 42 :-) ?

I am coming back to this and I think it may be better to just piggyback
on the ones that exist.

On x86 it is simple - just pick the most common one. On ARM - I have no clue?

Also having an 'LIVEPATCH_TEST" cpu configuration bit means it can be exposed
via the framework to domctl users. And that seems rather odd.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel