Re: [Xen-devel] [PATCH v1 2/9] x86/arm: Make 'make debug' work properly.

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Wed, Aug 17, 2016 at 06:00:22AM -0600, Jan Beulich wrote:
> >>> On 15.08.16 at 01:07, <konrad.wilk@xxxxxxxxxx> wrote:
> > On x86 it works great but on ARM 32,64 not so much.
> 
> Considering the nature of the change ...
> 
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -101,7 +101,7 @@ _uninstall:
> >  
> >  .PHONY: _debug
> >  _debug:
> > -   objdump -D -S $(TARGET)-syms > $(TARGET).s
> > +   $(OBJDUMP) -D -S $(TARGET)-syms > $(TARGET).s
> 
> ... I'd have expected breakage to be the other way around (works
> in native build but breaks in cross ones). Can you explain in which

Yes!
> way a plain objdump fails here in the native case?

I meant cross-builds. Doing compiling on ARM 32 proper platform
takes quite a while. And got so used that I am doing it now all the time.

> 
> Irrespective of that the patch of course if fine, i.e.
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> just that's it like it to be explained better.

Thank you. Changing the commit to say;

When doing cross-compilation we should use proper $(OBJDUMP).
Otherwise decompiling say ARM32 code using x86 objdump won't help much.

> 
> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel