Re: [Xen-devel] [PATCH] tools/xenalyze: append argp LD flags if needed

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 18/08/16 10:10, Roger Pau Monne wrote:
> This is a side-effect of commit c36e1c, which currently prevents compiling
> xenalyze with libcs that don't have argp built-in.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

I don't have the expertise to know if this is the Right Way to solve
this problem; but regarding the principle:

Acked-by: George Dunlap <george.dunlap@xxxxxxxxxx>

> ---
> Cc: George Dunlap <george.dunlap@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> ---
>  tools/xentrace/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile
> index a85ed33..c8c36a8 100644
> --- a/tools/xentrace/Makefile
> +++ b/tools/xentrace/Makefile
> @@ -50,7 +50,7 @@ xentrace_setsize: setsize.o
>       $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS) $(APPEND_LDFLAGS)
>  
>  xenalyze: xenalyze.o mread.o
> -     $(CC) $(LDFLAGS) -o $@ $^ $(APPEND_LDFLAGS)
> +     $(CC) $(LDFLAGS) -o $@ $^ $(ARGP_LDFLAGS) $(APPEND_LDFLAGS)
>  
>  -include $(DEPS)
>  
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel