Re: [Xen-devel] [PATCH 1/9] x86/mtrr: prefix fns with mtrr and drop static

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.08.16 at 03:38, <cardoe@xxxxxxxxxx> wrote:
> On 8/17/16 7:36 AM, Jan Beulich wrote:
>>>>> On 17.08.16 at 01:28, <cardoe@xxxxxxxxxx> wrote:
>>> For the functions that make up the interface to the MTRR code, drop the
>>> static keyword and prefix them all with mtrr for improved clarity when
>>> they're called outside this file. This also required adjusting or
>>> providing function prototypes to make them callable.
>> 
>> I can see why you want to do this for non-static functions, but I can't
>> see why static ones would need to get altered (unless you mean to call
>> them directly in subsequent patches, in which case the rationale above
>> should be adjusted). Nor can I see why the two functions previously
>> having been non-static can't simply be made static, without changing
>> their names, as the patch demonstrates that they don't have callers
>> in other CUs.
> 
> I've added:
> 
> Future changes will directly call these functions instead of using the
> indirect call through the ops structure.
> 
> Does that work?

Sure, having seen the further parts of the series.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel