Re: [Xen-devel] [PATCH 9/9] x86/mtrr: use stdbool instead of int + define

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.08.16 at 01:28, <cardoe@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/cpu/mtrr/generic.c
> +++ b/xen/arch/x86/cpu/mtrr/generic.c
> @@ -3,6 +3,7 @@
>  #include <xen/lib.h>
>  #include <xen/init.h>
>  #include <xen/mm.h>
> +#include <xen/stdbool.h>

Is this really needed, with xen/types.h already including it?

> @@ -237,7 +238,7 @@ static void mtrr_wrmsr(unsigned int msr, uint64_t 
> msr_content)
>   * \param changed pointer which indicates whether the MTRR needed to be 
> changed
>   * \param msrwords pointer to the MSR values which the MSR should have
>   */
> -static void set_fixed_range(int msr, int * changed, unsigned int * msrwords)
> +static void set_fixed_range(int msr, bool * changed, unsigned int * msrwords)

Please drop the stray blanks while touching this.

> @@ -478,7 +479,7 @@ void mtrr_generic_set(unsigned int reg, unsigned long 
> base,
>      <base> The base address of the region.
>      <size> The size of the region. If this is 0 the region is disabled.
>      <type> The type of the region.
> -    <do_safe> If TRUE, do the change safely. If FALSE, safety measures should
> +    <do_safe> If true, do the change safely. If false, safety measures should
>      be done externally.

Please drop this stale comment portion instead of adjusting it.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel