Re: [Xen-devel] [PATCH v1 3/9] x86/arm64: Move the ALT_[ORIG|REPL]_PTR macros to header files.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.08.16 at 01:07, <konrad.wilk@xxxxxxxxxx> wrote:
> That way common code can use the same macro to access
> the most common attributes without much #ifdef.
> 
> Take advantage of it right away in the livepatch code.
> 
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

x86 part
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
with one adjustment:

> --- a/xen/include/asm-x86/alternative.h
> +++ b/xen/include/asm-x86/alternative.h
> @@ -23,6 +23,10 @@ struct alt_instr {
>      u8  replacementlen;     /* length of new instruction, <= instrlen */
>  };
>  
> +#define __ALT_PTR(a,f)      (u8 *)((void *)&(a)->f + (a)->f)

This needs another set of parentheses around the entire expression
(also in the ARM variant).

And I'd like to also note that from an x86 perspective the "Move" in the
title isn't really correct.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel