Re: [Xen-devel] [PATCH biosdevname]: handle dom0 on AMD systems

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 17/08/16 12:51, Jan Beulich wrote:
>>>> On 17.08.16 at 12:30, <olaf@xxxxxxxxx> wrote:
>> @@ -144,7 +171,11 @@ running_in_virtual_machine (void)
>>  
>>      ecx = cpuid (eax, ecx);
>>      if (ecx & 0x80000000U)
>> +    {
>> +       if (running_in_dom0())
>> +           return 0;
>>         return 1;
>> +    }
>>      return 0;
>>  }
> Isn't this backwards? Dom0 _is_ a virtual machine.

biosdevname uses it as a "I should silently exit and do nothing" check.

This is unhelpful behaviour as dom0 is responsible for the real hardware.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel