Re: [Xen-devel] [PATCH] xentop: Adds options for tabs-separators, and including the domain ID in the output.

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Aug 15, 2016 at 01:09:32PM +0100, Wei Liu wrote:
> On Sat, Aug 13, 2016 at 05:51:21PM +0000, Stefan Wieser wrote:
> > This change adds two options to xentop:
> > 
> >         -T      adds a tabulator (\t) character after each field, to allow
> >                 easier and more robust parsing. This affects batch mode 
> > only.
> >         -I      includes a column with the domain ID in the output (both the
> >                 graphical output, and the batch output)
> > 
> > This makes the output easier to parse for automated tools.
> > If none of the options are passed, the output is unchanged, so none of them 
> > would break existing tools.
> 
> Line too long.
> 
> And thanks for having compatibility in mind.
> 
> > @@ -1235,9 +1273,19 @@ int main(int argc, char **argv)
> >             case 't':
> >                     show_tmem = 1;
> >                     break;
> > +           case 'T':
> > +                   use_tabs = 1;
> > +                   break;
> > +           case 'I':
> > +                   show_domid = 1;
> > +                   break;
> >             }
> >     }
> >  
> > +   if (use_tabs && !batch) {
> > +           fail("Cannot use tabs in interactive mode.\n");
> > +   }
> > +
> 
> Minor nit: no need to use {} here.
> 
> No need to resend, though. Should be easy to fix if I am to commit this
> patch.
> 
> All in all I have no opinion for a few new options. I will wait a few
> gays so that other people can express their opinions.
> 

^ days, sorry...

> Wei.
> 
> >     /* Get xenstat handle */
> >     xhandle = xenstat_init();
> >     if (xhandle == NULL)
> > -- 
> > 1.9.1
> > 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel