Re: [Xen-devel] [PATCH 2/2] x86/EFI: use less crude way of generating the build ID

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.08.16 at 01:42, <konrad@xxxxxxxxxx> wrote:
>> --- a/xen/arch/x86/efi/Makefile
>> +++ b/xen/arch/x86/efi/Makefile
>> @@ -9,6 +9,9 @@ efi := $(if $(efi),$(shell $(CC) $(filte
>>  efi := $(if $(efi),$(shell $(LD) -mi386pep --subsystem=10 -o check.efi 
>> check.o 2>disabled && echo y))
>>  efi := $(if $(efi),$(shell rm disabled)y,$(shell $(call 
>> create,boot.init.o); $(call create,runtime.o)))
>>  
>> -extra-$(efi) += boot.init.o relocs-dummy.o runtime.o compat.o
>> +extra-$(efi) += boot.init.o relocs-dummy.o runtime.o compat.o buildid.o
>> +
>> +%.o: %.ihex
>> +    $(OBJCOPY) -I ihex -O binary $< $@
> 
> 
> Under  Ubuntu 14.04.4 this fails compilation:
> 
> 
> make[4]: *** No rule to make target `buildid.o', needed by `stub.o'.

That's extremely odd, namely considering that the rule is right
there in the quoted text above. Could you double check
xen/arch/x86/efi/buildid.ihex is actually there?

> The properties of Ubuntu 14.04.4 are:
> konrad@ubuntu:~/xen$ gcc --version
> gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
> konrad@ubuntu:~/xen/xen$ ld --version
> GNU ld (GNU Binutils for Ubuntu) 2.24
> konrad@ubuntu:~/xen/xen$ ld -mi386pep
> ld: no input files
> 
> konrad@ubuntu:~/xen/xen$ cat /etc/debian_version 
> jessie/sid

For the error above the version of make is actually the most
relevant one (albeit for this trivial a rule I can't really how the
make version could matter). Since you've chopped off other
make output - does the error indeed occur in xen/arch/x86/efi/
(and not in xen/arch/x86/)? I agree this should be the case,
since in the other directory the printed name would have to be
efi/buildid.o - I'm just trying make sure impossible things really
are impossible.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel