Re: [Xen-devel] [Very RFC PATCH] Livepatch - initial ARM64/32 support.

[Julien Grall <julien.grall@xxxxxxx>]

On 09/08/2016 06:18, Konrad Rzeszutek Wilk wrote:
> Hey!
Hi Konrad,

> Over the last couple of months in my spare time I was playing
> with making livepatch work with ARM64 (using the FoundationModel
> simulator) and I finally got it working tonight.
Congrats!

> Sending out the patches just in case they don't work tomorrow :-)
>
> The ARM32 part is going slowly - as I don't have a simulator
> and using a real board takes time.
Whilst I can see usage of livepatch for Xen ARM64 (e.g server), I am 
less convinced for ARM32. I am bit worry to check-in code that will get 
rotten in the long term. So do you see any usage on ARM32?
> As you can see from the diffstat there is some room
> for improvement:
>  - The 'tests' - they are now in x86 and arm - and they are quite
>    similar. My thinking is to move them to 'common' ?
>  - There is room to unify some of the ELF relocation checks as
>    they are exactly the same across architectures.
>
> There is also an ugly implementation of modify_xen_mappings.
> I am hoping the ARM maintainers could provide some input on
> how they would like me to implement this.
I will give a look and comment on the patch.

[...]

> Konrad Rzeszutek Wilk (3):
>       mm/arm: Introduce modify_xen_mappings
>       insn: Add arch64_insn_gen_branch_imm to generate branch
>       livepatch: Initial ARM32/64 support.
Do you plan to split the last patch in smaller patches?

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel