Re: [Xen-devel] [PATCH 2/2] x86/altp2m: allow specifying external-only use-case

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

>>> --- a/xen/include/public/hvm/params.h
>>> +++ b/xen/include/public/hvm/params.h
>>> @@ -225,8 +225,16 @@
>>>  /* Location of the VM Generation ID in guest physical address space. */
>>>  #define HVM_PARAM_VM_GENERATION_ID_ADDR 34
>>>
>>> -/* Boolean: Enable altp2m */
>>> +/*
>>> + * Set mode for altp2m:
>>> + *  disabled: don't activate altp2m (default)
>>> + *  mixed: allow access to altp2m for both in-guest and external tools
>>> + *  external_only: allow access to external privileged tools only
>>> + */
>>>  #define HVM_PARAM_ALTP2M       35
>>> +#define HVMALTP2M_disabled      0
>>> +#define HVMALTP2M_mixed         1
>>> +#define HVMALTP2M_external_only 2
>>
>> No new classes / groups of identifiers in the public interface please
>> which are in violation of the name spacing rules (read: should be
>> prefixed by XEN_).
>
> Ack.

Should it be XEN_ALTP2M_* or XEN_HVMALTP2M_*? I prefer the former as
it's a bit more readable.

Thanks,
Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel