Re: [Xen-devel] [PATCH v4 02/19] x86/boot: remove multiboot1_header_end from symbol table

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.08.16 at 15:24, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 06/08/16 00:04, Daniel Kiper wrote:
>> --- a/xen/arch/x86/boot/head.S
>> +++ b/xen/arch/x86/boot/head.S
>> @@ -32,7 +32,7 @@ multiboot1_header_start:       /*** MULTIBOOT1 HEADER ****/
>>          .long   MULTIBOOT_HEADER_FLAGS
>>          /* Checksum: must be the negated sum of the first two fields. */
>>          .long   -(MULTIBOOT_HEADER_MAGIC + MULTIBOOT_HEADER_FLAGS)
>> -multiboot1_header_end:
>> +.Lmultiboot1_header_end:
> 
> I put this in as a non local symbol for a very good reason, and see no
> justification to change it.
> 
> It is very important to be able to distinguish data from opcode in the
> disassembly, and one extra global symbol will not break the bank.

Well, I was about to commit it, but will hold of now that you object.
Nevertheless I disagree, and would like to see the patch go in: If
there is code starting past this label, then that code should itself
have a label, and any padding between the end label above and the
code start label is neither code nor data anyway.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel