Re: [Xen-devel] [PATCH v2 4/6] libxl: libxl_{primary_, }console_exec now take notify_fd argument

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("[PATCH v2 4/6] libxl: libxl_{primary_,}console_exec now take 
notify_fd argument"):
> The new argument will be passed down to xenconsole process, which then
> uses it to notify readiness.
...
> -    execl(p, p, domid_s, "--num", cons_num_s, "--type", cons_type_s, (void 
> *)NULL);
> +    if (notify_fd != -1) {
> +        notify_fd_s = GCSPRINTF("%d", notify_fd);
> +        execl(p, p, domid_s, "--num", cons_num_s, "--type", cons_type_s,
> +              "--start-notify-fd", notify_fd_s, (void *)NULL);
> +    } else
> +        execl(p, p, domid_s, "--num", cons_num_s, "--type", cons_type_s,
> +              (void *)NULL);

Technically this braces-then-non-braces conforms to the spec in
CODING_STYLE but not to the style elsewhere in libxl.  Could you put
braces around the else clause too ?

Sorry for not noticing this earlier.  We can fix this on checkin if
you like.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel