[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [xen-4.6-testing bisection] complete test-amd64-amd64-xl-pvh-intel
branch xen-4.6-testing xenbranch xen-4.6-testing job test-amd64-amd64-xl-pvh-intel testid xen-boot Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: 477080fc560a3025d451175b69995e62a2ce1a8d Bug not present: ec712ba0838b7d7fb11229d1a5ab42978c14a782 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/99995/ commit 477080fc560a3025d451175b69995e62a2ce1a8d Author: George Dunlap <george.dunlap@xxxxxxxxxx> Date: Fri Aug 5 13:47:04 2016 +0200 xen: Have schedulers revise initial placement The generic domain creation logic in xen/common/domctl.c:default_vcpu0_location() attempts to try to do initial placement load-balancing by placing vcpu 0 on the least-busy non-primary hyperthread available. Unfortunately, the logic can end up picking a pcpu that's not in the online mask. When this is passed to a scheduler such which assumes that the initial assignment is valid, it causes a null pointer dereference looking up the runqueue. Furthermore, this initial placement doesn't take into account hard or soft affinity, or any scheduler-specific knowledge (such as historic runqueue load, as in credit2). To solve this, when inserting a vcpu, always call the per-scheduler "pick" function to revise the initial placement. This will automatically take all knowledge the scheduler has into account. csched2_cpu_pick ASSERTs that the vcpu's pcpu scheduler lock has been taken. Grab and release the lock to minimize time spend with irqs disabled. Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxx> Reviewed-by: Meng Xu <mengxu@xxxxxxxxxxxxx> Reviwed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx> master commit: 9f358ddd69463fa8fb65cf67beb5f6f0d3350e32 master date: 2016-07-26 10:42:49 +0100 For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-4.6-testing/test-amd64-amd64-xl-pvh-intel.xen-boot.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-4.6-testing/test-amd64-amd64-xl-pvh-intel.xen-boot --summary-out=tmp/99995.bisection-summary --basis-template=99902 --blessings=real,real-bisect xen-4.6-testing test-amd64-amd64-xl-pvh-intel xen-boot Searching for failure / basis pass: 99962 fail [host=italia1] / 99902 ok. Failure / basis pass flights: 99962 / 99902 (tree with no url: minios) (tree with no url: ovmf) (tree with no url: seabios) Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Latest da99423b3cd3e48c42c0d64b79aba58d828f9648 c530a75c1e6a472b0eb9558310b518f0dfcd8860 29b39dac29529b9989e4f597adb354f7879b6f63 ebfc90b51d09e0a3330a4702bb23223cf088eabd ff49c274e93cf5524b7d108aea8c792b13fe27c8 Basis pass da99423b3cd3e48c42c0d64b79aba58d828f9648 c530a75c1e6a472b0eb9558310b518f0dfcd8860 29b39dac29529b9989e4f597adb354f7879b6f63 ebfc90b51d09e0a3330a4702bb23223cf088eabd 625c3e47e077129b0bc903e8db03bdf1cbbeb413 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/linux-pvops.git#da99423b3cd3e48c42c0d64b79aba58d828f9648-da99423b3cd3e48c42c0d64b79aba58d828f9648 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/qemu-xen-traditional.git#29b39dac29529b9989e4f597adb354f7879b6f63-29b39dac29529b9989e4f597adb354f7879b6f63 git://xenbits.xen.org/qemu-xen.git#ebfc90b51d09e0a3330a4702bb23223cf088eabd-ebfc90b51d09e0a3330a4702bb23223cf088eabd git://xenbits.xen.org/xen.git#625c3e47e077129b0bc903e8db03bdf1cbbeb413-ff49c274e93cf5524b7d108aea8c792b13fe27c8 Loaded 1001 nodes in revision graph Searching for test results: 99894 pass da99423b3cd3e48c42c0d64b79aba58d828f9648 c530a75c1e6a472b0eb9558310b518f0dfcd8860 29b39dac29529b9989e4f597adb354f7879b6f63 ebfc90b51d09e0a3330a4702bb23223cf088eabd 625c3e47e077129b0bc903e8db03bdf1cbbeb413 99995 fail da99423b3cd3e48c42c0d64b79aba58d828f9648 c530a75c1e6a472b0eb9558310b518f0dfcd8860 29b39dac29529b9989e4f597adb354f7879b6f63 ebfc90b51d09e0a3330a4702bb23223cf088eabd 477080fc560a3025d451175b69995e62a2ce1a8d 99902 pass da99423b3cd3e48c42c0d64b79aba58d828f9648 c530a75c1e6a472b0eb9558310b518f0dfcd8860 29b39dac29529b9989e4f597adb354f7879b6f63 ebfc90b51d09e0a3330a4702bb23223cf088eabd 625c3e47e077129b0bc903e8db03bdf1cbbeb413 99990 pass da99423b3cd3e48c42c0d64b79aba58d828f9648 c530a75c1e6a472b0eb9558310b518f0dfcd8860 29b39dac29529b9989e4f597adb354f7879b6f63 ebfc90b51d09e0a3330a4702bb23223cf088eabd ec712ba0838b7d7fb11229d1a5ab42978c14a782 99962 fail da99423b3cd3e48c42c0d64b79aba58d828f9648 c530a75c1e6a472b0eb9558310b518f0dfcd8860 29b39dac29529b9989e4f597adb354f7879b6f63 ebfc90b51d09e0a3330a4702bb23223cf088eabd ff49c274e93cf5524b7d108aea8c792b13fe27c8 99986 pass da99423b3cd3e48c42c0d64b79aba58d828f9648 c530a75c1e6a472b0eb9558310b518f0dfcd8860 29b39dac29529b9989e4f597adb354f7879b6f63 ebfc90b51d09e0a3330a4702bb23223cf088eabd ec712ba0838b7d7fb11229d1a5ab42978c14a782 99984 fail da99423b3cd3e48c42c0d64b79aba58d828f9648 c530a75c1e6a472b0eb9558310b518f0dfcd8860 29b39dac29529b9989e4f597adb354f7879b6f63 ebfc90b51d09e0a3330a4702bb23223cf088eabd ff49c274e93cf5524b7d108aea8c792b13fe27c8 99975 pass da99423b3cd3e48c42c0d64b79aba58d828f9648 c530a75c1e6a472b0eb9558310b518f0dfcd8860 29b39dac29529b9989e4f597adb354f7879b6f63 ebfc90b51d09e0a3330a4702bb23223cf088eabd 625c3e47e077129b0bc903e8db03bdf1cbbeb413 99988 fail da99423b3cd3e48c42c0d64b79aba58d828f9648 c530a75c1e6a472b0eb9558310b518f0dfcd8860 29b39dac29529b9989e4f597adb354f7879b6f63 ebfc90b51d09e0a3330a4702bb23223cf088eabd 477080fc560a3025d451175b69995e62a2ce1a8d 99991 fail da99423b3cd3e48c42c0d64b79aba58d828f9648 c530a75c1e6a472b0eb9558310b518f0dfcd8860 29b39dac29529b9989e4f597adb354f7879b6f63 ebfc90b51d09e0a3330a4702bb23223cf088eabd 477080fc560a3025d451175b69995e62a2ce1a8d 99993 pass da99423b3cd3e48c42c0d64b79aba58d828f9648 c530a75c1e6a472b0eb9558310b518f0dfcd8860 29b39dac29529b9989e4f597adb354f7879b6f63 ebfc90b51d09e0a3330a4702bb23223cf088eabd ec712ba0838b7d7fb11229d1a5ab42978c14a782 Searching for interesting versions Result found: flight 99894 (pass), for basis pass Result found: flight 99962 (fail), for basis failure Repro found: flight 99975 (pass), for basis pass Repro found: flight 99984 (fail), for basis failure 0 revisions at da99423b3cd3e48c42c0d64b79aba58d828f9648 c530a75c1e6a472b0eb9558310b518f0dfcd8860 29b39dac29529b9989e4f597adb354f7879b6f63 ebfc90b51d09e0a3330a4702bb23223cf088eabd ec712ba0838b7d7fb11229d1a5ab42978c14a782 No revisions left to test, checking graph state. Result found: flight 99986 (pass), for last pass Result found: flight 99988 (fail), for first failure Repro found: flight 99990 (pass), for last pass Repro found: flight 99991 (fail), for first failure Repro found: flight 99993 (pass), for last pass Repro found: flight 99995 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: 477080fc560a3025d451175b69995e62a2ce1a8d Bug not present: ec712ba0838b7d7fb11229d1a5ab42978c14a782 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/99995/ commit 477080fc560a3025d451175b69995e62a2ce1a8d Author: George Dunlap <george.dunlap@xxxxxxxxxx> Date: Fri Aug 5 13:47:04 2016 +0200 xen: Have schedulers revise initial placement The generic domain creation logic in xen/common/domctl.c:default_vcpu0_location() attempts to try to do initial placement load-balancing by placing vcpu 0 on the least-busy non-primary hyperthread available. Unfortunately, the logic can end up picking a pcpu that's not in the online mask. When this is passed to a scheduler such which assumes that the initial assignment is valid, it causes a null pointer dereference looking up the runqueue. Furthermore, this initial placement doesn't take into account hard or soft affinity, or any scheduler-specific knowledge (such as historic runqueue load, as in credit2). To solve this, when inserting a vcpu, always call the per-scheduler "pick" function to revise the initial placement. This will automatically take all knowledge the scheduler has into account. csched2_cpu_pick ASSERTs that the vcpu's pcpu scheduler lock has been taken. Grab and release the lock to minimize time spend with irqs disabled. Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxx> Reviewed-by: Meng Xu <mengxu@xxxxxxxxxxxxx> Reviwed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx> master commit: 9f358ddd69463fa8fb65cf67beb5f6f0d3350e32 master date: 2016-07-26 10:42:49 +0100 Revision graph left in /home/logs/results/bisect/xen-4.6-testing/test-amd64-amd64-xl-pvh-intel.xen-boot.{dot,ps,png,html,svg}. ---------------------------------------- 99995: tolerable ALL FAIL flight 99995 xen-4.6-testing real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/99995/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: test-amd64-amd64-xl-pvh-intel 6 xen-boot fail baseline untested jobs: test-amd64-amd64-xl-pvh-intel fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |