Re: [Xen-devel] [PATCH 3/3] x86/microcode: Avoid undefined behaviour from signed integer overflow

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.08.16 at 15:50, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/microcode_intel.c
> +++ b/xen/arch/x86/microcode_intel.c
> @@ -143,7 +143,8 @@ static int microcode_sanity_check(void *mc)
>      struct extended_sigtable *ext_header = NULL;
>      struct extended_signature *ext_sig;
>      unsigned long total_size, data_size, ext_table_size;
> -    int sum, orig_sum, ext_sigcount = 0, i;
> +    uint32_t sum, orig_sum;
> +    int ext_sigcount = 0, i;

Pretty clearly these other two want to be unsigned int? If you agree,
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel