Re: [Xen-devel] [PATCH 1/9] x86/hypercall: Move some of the hvm hypercall infrastructure into hypercall.h

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.07.16 at 11:51, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/include/asm-x86/hypercall.h
> +++ b/xen/include/asm-x86/hypercall.h
> @@ -5,9 +5,21 @@
>  #ifndef __ASM_X86_HYPERCALL_H__
>  #define __ASM_X86_HYPERCALL_H__
>  
> +#include <xen/types.h>
>  #include <public/physdev.h>
> +#include <public/event_channel.h>

Why?

>  #include <public/arch-x86/xen-mca.h> /* for do_mca */
> -#include <xen/types.h>
> +
> +typedef unsigned long hypercall_fn_t(
> +    unsigned long, unsigned long, unsigned long,
> +    unsigned long, unsigned long, unsigned long);

Wouldn't this better go into xen/hypercall.h?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel