Re: [Xen-devel] [PATCH v2 02/25] arm/altp2m: Add HVMOP_altp2m_get_domain_state.

[Sergej Proskurin <proskurin@xxxxxxxxxxxxx>]

Hi Andrew,

On 08/01/2016 07:21 PM, Andrew Cooper wrote:
> On 01/08/16 18:10, Sergej Proskurin wrote:
>> diff --git a/xen/include/asm-arm/altp2m.h b/xen/include/asm-arm/altp2m.h
>> index 0711796..d47b249 100644
>> --- a/xen/include/asm-arm/altp2m.h
>> +++ b/xen/include/asm-arm/altp2m.h
>> @@ -22,6 +22,8 @@
>>  
>>  #include <xen/sched.h>
>>  
>> +#define altp2m_enabled(d) ((d)->arch.hvm_domain.params[HVM_PARAM_ALTP2M])
> 
> This macro expects to be used as a predicate, but may return non-boolean
> values.  You should use
> (!!(d)->arch.hvm_domain.params[HVM_PARAM_ALTP2M]) to make sure it is
> strictly 1 or 0 being returned.
> 

I will fix that, thank you.

Best regards,
~Sergej

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel