Re: [Xen-devel] [PATCHv1] xen/evtchn: add IOCTL_EVTCHN_RESTRICT

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 01/08/16 12:15, Jan Beulich wrote:
>>>> On 11.07.16 at 16:57, <david.vrabel@xxxxxxxxxx> wrote:
>> @@ -553,6 +570,27 @@ static long evtchn_ioctl(struct file *file,
>>              break;
>>      }
>>  
>> +    case IOCTL_EVTCHN_RESTRICT_DOMID: {
>> +            struct ioctl_evtchn_restrict_domid ierd;
>> +
>> +            rc = -EACCES;
>> +            if (u->restrict_domid != UNRESTRICTED_DOMID)
>> +                    break;
>> +
>> +            rc = -EFAULT;
>> +            if (copy_from_user(&ierd, uarg, sizeof(ierd)))
>> +                break;
>> +
>> +            rc = -EINVAL;
>> +            if (ierd.domid == 0 || ierd.domid >= DOMID_FIRST_RESERVED)
>> +                    break;
> 
> Any reason you special case Dom0 here, but not the conceptually
> more general hardware and/or control domain?

I don't know why that check is there.  I think it can be removed.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel