Re: [Xen-devel] [PATCH v3 0/4] tools: make xenstore domain/daemon configurable

[Juergen Gross <jgross@xxxxxxxx>]

On 22/07/16 17:09, Juergen Gross wrote:
> Add a configuration option to /etc/sysconfig/xencommons to let the
> user configure whether he wants to start xenstore service as a daemon
> or as a stubdom.
> 
> Changes in V3:
> - patch 1: re-add sd_notify() call
> - split up former patch 2 into 3 patches as requested by Ian Jackson
> - patch 4 (was 2): remove check for running xenstore domain, as this 
>   is done in init-xenstore-domain already
> - patch 4 (was 2): if booted with systemd send a systemd-notify message 
>   in the xenstore domain case
> - patch 4 (was 2): if booted with systemd don't wait until xenstore 
>   daemon is running, as the daemon will have sent a notify message by 
>   its own
> 
> Changes in V2:
> - move service type modification form patch 2 to patch 1 as implied by
>   Ross Lagerwall (at least I guess so)
> - add .gitignore entry for launch-xenstore

I think I have addressed all concerns raised on version 1 and 2 of this
series. Did I miss anything?


Juergen

> 
> Juergen Gross (4):
>   tools: remove systemd xenstore socket definitions
>   tools: split out xenstored starting form xencommons
>   tools: use pidfile for test if xenstored is running
>   tools: make xenstore domain easy configurable
> 
>  .gitignore                                         |   1 +
>  tools/configure                                    |   7 +-
>  tools/configure.ac                                 |   3 +-
>  tools/hotplug/Linux/Makefile                       |   1 +
>  tools/hotplug/Linux/init.d/sysconfig.xencommons.in |  42 +++++++-
>  tools/hotplug/Linux/init.d/xencommons.in           |  38 +------
>  tools/hotplug/Linux/launch-xenstore.in             |  87 ++++++++++++++++
>  tools/hotplug/Linux/systemd/Makefile               |   5 -
>  tools/hotplug/Linux/systemd/xenstored.service.in   |  13 +--
>  tools/hotplug/Linux/systemd/xenstored.socket.in    |  13 ---
>  tools/hotplug/Linux/systemd/xenstored_ro.socket.in |  13 ---
>  tools/ocaml/xenstored/systemd.ml                   |   1 -
>  tools/ocaml/xenstored/systemd.mli                  |   5 -
>  tools/ocaml/xenstored/systemd_stubs.c              | 113 
> ++++-----------------
>  tools/ocaml/xenstored/utils.ml                     |  21 ++--
>  tools/xenstore/xenstored_core.c                    |  92 +----------------
>  16 files changed, 169 insertions(+), 286 deletions(-)
>  create mode 100644 tools/hotplug/Linux/launch-xenstore.in
>  delete mode 100644 tools/hotplug/Linux/systemd/xenstored.socket.in
>  delete mode 100644 tools/hotplug/Linux/systemd/xenstored_ro.socket.in
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel