Re: [Xen-devel] [RFC 13/22] xen/arm: p2m: Replace all usage of __p2m_lookup with p2m_get_entry

[Tamas K Lengyel <tamas@xxxxxxxxxxxxx>]

On Fri, Jul 29, 2016 at 9:06 AM, Julien Grall <julien.grall@xxxxxxx> wrote:
>
>
> On 28/07/16 18:36, Tamas K Lengyel wrote:
>>
>> On Thu, Jul 28, 2016 at 11:29 AM, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
>> wrote:
>>>
>>> On Thu, Jul 28, 2016 at 8:51 AM, Julien Grall <julien.grall@xxxxxxx>
>>> wrote:
>>>>
>>>> __p2m_lookup is just a wrapper to p2m_get_entry.
>>>>
>>>> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
>>>> Cc: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
>>>> Cc: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
>>>>
>>>> ---
>>>>     It might be possible to rework the memaccess code to take advantage
>>>>     of all the parameters. I will defer this to the memaccess folks.
>>>
>>>
>>> Could you elaborate on what you mean?
>>>
>>
>> Never mind, I see it. Yes, doing __p2m_get_mem_access and then
>> p2m_get_entry later duplicates work. I would suggest just replacing
>> __p2m_get_mem_access with a single call to p2m_get_entry to get both
>> the type and the mem_access setting on the page in a single run.
>
>
> I am not planning to clean-up the memaccess code. Feel free to send a
> follow-up patch for that.
>

Since you are already touching this code you might as well but
whatever, up to you.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel