[Xen-devel] [PATCH] xen/kconfig: unify messages of options moved from command line to kconfig

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

Change the message so that it mentions running from the top level directory
and using '-C xen' in order to call the 'menuconfig' target inside of the
xen directory (there's no top-level menuconfig target).

Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Cc: Jan Beulich <jbeulich@xxxxxxxx>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Cc: Tim Deegan <tim@xxxxxxx>
Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
Cc: Doug Goldstein <cardoe@xxxxxxxxxx>
---
 xen/Rules.mk | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/xen/Rules.mk b/xen/Rules.mk
index ebe1dc0..8fc44d3 100644
--- a/xen/Rules.mk
+++ b/xen/Rules.mk
@@ -9,27 +9,31 @@ lto           ?= n
 
 include $(XEN_ROOT)/Config.mk
 
+error_str = "You must use '$(MAKE) -C xen menuconfig' from the top level 
directory to enable/disable $(1) now."
+error_msg = $(error $(error_str))
+warning_msg = $(warning $(error_str))
+
 
 ifneq ($(origin crash_debug),undefined)
-$(error "You must use 'make menuconfig' to enable/disable crash_debug now.")
+$(call error_msg,crash_debug)
 endif
 ifeq ($(origin debug),command line)
-$(warning "You must use 'make menuconfig' to enable/disable debug now.")
+$(call warning_msg,debug)
 endif
 ifneq ($(origin frame_pointer),undefined)
-$(error "You must use 'make menuconfig' to enable/disable frame_pointer now.")
+$(call error_msg,frame_pointer)
 endif
 ifneq ($(origin kexec),undefined)
-$(error "You must use 'make menuconfig' to enable/disable kexec now.")
+$(call error_msg,kexec)
 endif
 ifneq ($(origin lock_profile),undefined)
-$(error "You must use 'make menuconfig' to enable/disable lock_profile now.")
+$(call error_msg,lock_profile)
 endif
 ifneq ($(origin perfc),undefined)
-$(error "You must use 'make menuconfig' to enable/disable perfc now.")
+$(call error_msg,perfc)
 endif
 ifneq ($(origin verbose),undefined)
-$(error "You must use 'make menuconfig' to enable/disable verbose now.")
+$(call error_msg,verbose)
 endif
 
 # Set ARCH/SUBARCH appropriately.
-- 
2.7.4 (Apple Git-66)


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel