Re: [Xen-devel] [PATCH 1/6] libxl: add "merge" function to generic device type support

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Jul 12, 2016 at 05:30:39PM +0200, Juergen Gross wrote:
> Instead of using a macro generating the code to merge xenstore and
> json configuration data, use the generic device type support for
> this purpose.
> 
> This requires to add some accessor functions to the framework and
> a structure for disks (as disks are added separately they didn't need
> such a structure up to now).
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

I definitely think this is a good idea.

The code looks good to me:

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

I didn't do a line-by-line review though because most code looks very
mechanical. I'm confident that we can sort out issues should they arise.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel