Re: [Xen-devel] [PATCH v5 2/7] xen/arm: cpufeature: Provide an helper to check if a capability is supported

[Julien Grall <julien.grall@xxxxxxx>]

Hi Konrad,

On 22/07/16 15:18, Konrad Rzeszutek Wilk wrote:
> On Wed, Jul 20, 2016 at 04:25:55PM +0100, Julien Grall wrote:
> > diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c
> > index 7a1b56b..088625b 100644
> > --- a/xen/arch/arm/cpufeature.c
> > +++ b/xen/arch/arm/cpufeature.c
> > @@ -24,6 +24,22 @@
> >
> >  DECLARE_BITMAP(cpu_hwcaps, ARM_NCAPS);
> >
> > +void update_cpu_capabilities(const struct arm_cpu_capabilities *caps,
> > +                             const char *info)
> > +{
> > +    int i;
> > +
> > +    for ( i = 0; caps[i].matches; i++ )
> > +    {
> > +        if ( !caps[i].matches(&caps[i]) )
> So what if the 'struct arm_cpu_capabilitues' has '->matches' set to
> NULL?
It is the exit condition of the loop:

 for ( i = 0; caps[i].matches; i++ )

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel