Re: [Xen-devel] [PATCH XTF] build: introduce a dist target

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 20/07/16 12:55, Wei Liu wrote:
> The install target doesn't honour $PREFIX. Introduce a dist target to
> make it easier to package the artifacts.
>
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  Makefile | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 1a8099d..d625b90 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1,6 +1,7 @@
>  MAKEFLAGS += -r
>  ROOT := $(abspath $(CURDIR))
>  DESTDIR ?= $(ROOT)/dist
> +DISTDIR ?= $(ROOT)/dist
>  PREFIX ?= $(ROOT)
>  
>  .PHONY: all
> @@ -10,6 +11,10 @@ all:
>               $(MAKE) -C $$D build; \
>       done
>  
> +.PHONY: dist
> +dist: DESTDIR=$(DISTDIR)$(PREFIX)
> +dist: install

Thusfar, I have been following GNU coding standards.

I don't see any references to DISTDIR, and this usage if `make dist` is
incompatible with the standard expectation.

FWIW, `make dist` seems incompatible with XTF at the moment, because of
the embedded absolute paths needed in the written xl configuration files.



For XenServer, my RPM configuration is:

%{__make} %{?_smp_mflags} install DESTDIR=%{buildroot}/opt/%{name}
PREFIX=/opt/%{name}

to get `make install` to put the content sensibly in the build root, and
to generate files with correct absolute paths.

How are you intending to make use of this new `make dist` target?

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel