Re: [Xen-devel] [PATCH V2 2/4] xen: Add generic implementation of binary search

[Julien Grall <julien.grall@xxxxxxx>]

On 20/07/16 12:25, Julien Grall wrote:
> Hi Shanker,
>
> On 18/07/16 00:26, Shanker Donthineni wrote:
> > This patch adds the generic implementation of binary search algorithm
> > whcih is copied from Linux kernel v4.7-rc7. No functional changes.
> NIT: ws/whcih/which/
>
> > Signed-off-by: Shanker Donthineni <shankerd@xxxxxxxxxxxxxx>
> > Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> FWIW:
>
> Reviewed-by: Julien Grall <julien.grall@xxxxxxx>
Please ignore this, see why below...

> > diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h
> > index b1b0fb2..b90d582 100644
> > --- a/xen/include/xen/lib.h
> > +++ b/xen/include/xen/lib.h
> > @@ -153,4 +153,7 @@ void dump_execstate(struct cpu_user_regs *);
> >
> >  void init_constructors(void);
> >
> > +void *bsearch(const void *key, const void *base, size_t num, size_t
> > size,
> > +              int (*cmp)(const void *key, const void *elt))
Actually, there is a missing ';' which lead to a compilation failure. 
Please try to compile and test this series.
I will wait before reviewing the rest of this series.

> > +
> >  #endif /* __LIB_H__ */
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel