[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 1/2] xen: fix a (latent) cpupool-related race during domain destroy



On 18/07/16 16:03, Dario Faggioli wrote:
> On Fri, 2016-07-15 at 16:23 +0200, Dario Faggioli wrote:
>> On Fri, 2016-07-15 at 14:52 +0200, Juergen Gross wrote:
>>> On 15/07/16 13:52, Dario Faggioli wrote:
>>>> Therefore, I still think this patch is correct, but I'm up for
>>>> investigating further and finding a way to solve the "zombie in
>>>> cpupool" issue as well.
>>> I'm not saying your patch is wrong. I just wanted to give you a
>>> hint
>>> about the history of the stuff you are changing. :-)
>>>
>> Sure, and that's much appreciated! :-)
>>
>>> If it is working I'd really prefer it over the current situation.
>>>
>> Right. I've got to leave now. But I'll produce some zombies on
>> Monday,
>> and will see if they move. :-D
>>
> Here you go:
> 
> http://pastebin.com/r93TGCZU
> 
> Is that "vm1 -b-" --> "(null) ---" domain zombie enough?

Yes, seems to be okay for a zombie.

> If yes, as you can see, it moves to cpupool0 while being destroyed, and
> I can destroy the pool without problems.

Great.

> I also shutdown the system with the domain still there (in cpupool0),
> and it works.

Fine. You can add

Acked-by: Juergen Gross <jgross@xxxxxxxx>

for this patch then.


Thanks, Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.