Re: [Xen-devel] [PATCH RESEND 2/4] xen: Add generic implementation of binary search

[Shanker Donthineni <shankerd@xxxxxxxxxxxxxx>]

Hi Andrew,

On 07/15/2016 12:42 PM, Andrew Cooper wrote:
> On 15/07/16 18:35, Shanker Donthineni wrote:
> > This patch adds the generic implementation of binary search algorithm
> > whcih is copied from Linux kernel v4.7-rc7. No functional changes.
> >
> > Signed-off-by: Shanker Donthineni <shankerd@xxxxxxxxxxxxxx>
> > ---
> >   Resend to fix the In-Reply-To/References header feilds.
> >
> >   xen/common/Makefile       |  1 +
> >   xen/common/bsearch.c      | 51
> +++++++++++++++++++++++++++++++++++++++++++++++
> >   xen/include/xen/bsearch.h |  9 +++++++++
> Having a header file for a single is silly (I have no idea why Linux
> does it like that).
>
> I would move it into xen/lib.h which contains a number of other
> stdlib.h-like functions.
>
> With that done, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
I'll follow your suggestion.

--
Shanker Donthineni
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm 
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux 
Foundation Collaborative Project.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel