Re: [Xen-devel] [PATCH v4 1/7] asm-arm/atomic.h: fix arm32|arm64 macros duplication

[Julien Grall <julien.grall@xxxxxxx>]

On 15/07/16 10:55, Corneliu ZUZU wrote:
> On 7/15/2016 12:28 PM, Julien Grall wrote:
> > Hi Corneliu,
> >
> > On 15/07/16 07:48, Corneliu ZUZU wrote:
> > > Move duplicate macros between asm-arm/arm32/atomic.h and
> > > asm-arm/arm64/atomic.h
> > > to asm-arm/atomic.h. Adjust README.LinuxPrimitives in the process.
> > > Also empty line fixes.
> > Why do you add empty lines?
> A little picky today, aren't we? :-)
Same as usual ;).

[...]

> > They are not necessary nor coding style requirement nor in Linux
> > headers. Please don't introduce changes without a valid reason.
> I just peeked in the Linux source tree and I noticed there are also
> headers there with an empty line between the file-comment and #ifndef.
> Plus, this is the Xen code-base and I don't see why I'd look in the
> Linux source tree to determine rules that apply to the Xen source-tree.
Because files taken from Linux respect Linux coding style.

I did the mistake on other files to diverge (such as the SMMU code) and 
it was a pain to re-sync it later. So I prefer to have a strict rule on 
it, even for cosmetic changes.
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel