Re: [Xen-devel] [PATCH 03/16] x86/monitor: mechanical renames

[Tamas K Lengyel <tamas@xxxxxxxxxxxxx>]

On Fri, Jul 8, 2016 at 10:13 PM, Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx> wrote:
> Arch-specific vm-event functions in x86/vm_event.h -e.g. 
> vm_event_init_domain()-
> don't have an 'arch_' prefix. Apply the same rule for monitor functions -
> originally the only two monitor functions that had an 'arch_' prefix were
> arch_monitor_domctl_event() and arch_monitor_domctl_op(), but I gave them that
> prefix because -they had a counterpart function in common code-, that being
> monitor_domctl().

This should actually be the other way around - ie adding the arch_
prefix to vm_event functions that lack it. Having the arch_ prefix is
helpful to know that the function is dealing with the arch specific
structs and not common. Similarly that's why we have the hvm_ prefix
for functions in hvm/monitor.

>
> Let this also be the rule for future 'arch_' functions additions, and with 
> this
> patch remove the 'arch_' prefix from the monitor functions that don't have a
> counterpart in common-code (all but those 2 aforementioned).

Even if there are no common counter-parts to the function, the arch_
prefix should remain, so I won't be able to ack this patch.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel