Re: [Xen-devel] [PATCH v1 12/20] acpi/hvmloader: Link ACPI object files directly

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 07/08/2016 10:51 AM, Jan Beulich wrote:
>
>> +ACPI_FILES = dsdt_anycpu.c dsdt_15cpu.c dsdt_anycpu_qemu_xen.c build.c 
>> static_tables.c
>> +ACPI_OBJS = $(patsubst %.c,%.o,$(ACPI_FILES))
>> +$(ACPI_OBJS): CFLAGS += -I$(ACPI_PATH) -I.
> What is the -I. needed for? The ACPI files shouldn't be referencing
> other hvmloader files, and generated .h files should be included
> using "" instead of <>.


That's because we are building in tools/firmware/hvmloader (not
tools/firmware/hvmloader/acpi) and, for example, build.c includes header
files generated into tools/firmware/hvmloader. I also don't like adding
this but couldn't come up with a better solution.


>
> -
>  clean:
> -     rm -rf *.a *.o $(IASL_VER) $(IASL_VER).tar.gz $(DEPS)
> -     rm -rf ssdt_*.h dsdt*.c *~ *.aml *.hex mk_dsdt dsdt_*.asl
> +     rm -fr $(C_SRC) $(H_SRC) $(MK_DSDT) $(patsubst %.c,%.asl,$(C_SRC))
> It seems to me that this would better done in from the consumer's
> clean rule.


How does the consumer know what to clean? For example, some generated
header files are not directly used by the consumer.


-boris



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel