Re: [Xen-devel] [PATCH v1] hvmloader, pci: Don't try to relocate memory if 64-bit BAR is bigger than 4GB

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.07.16 at 17:27, <konrad.wilk@xxxxxxxxxx> wrote:
>> > @@ -451,7 +462,10 @@ void pci_setup(void)
>> >                  resource = &mem_resource;
>> >                  bar_data &= ~PCI_BASE_ADDRESS_MEM_MASK;
>> >              }
>> > -            mmio_total -= bar_sz;
>> > +            if ( bars[i].is_64bar && bar_sz > (1ull<<32) )
>> 
>> Now that you use this constant a second time, it clearly needs to
>> become a #define.
> 
> Do you have a preference on the ull? Most of the code has ull but there
> are two instances of ULL?

Not really. I kind of dislike both of them.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel