Re: [Xen-devel] [PATCH] tools/hotplug: Add native systemd xendriverdomain.service

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Sun, Jul 03, 2016 at 03:33:01AM +0000, Rusty Bird wrote:
> Uses ConditionVirtualization=xen, which evaluates to false in dom0 since
> systemd 214 (released 2014-06-11). An alternative would be this line:
> ExecStartPre=/bin/sh -c "! grep -q control_d /proc/xen/capabilities"
> 
> (Please rerun autogen.sh)
> 

While I understand it might be necessary to have a dedicated service
file for xendriverdomain, I can't seem to be able to figure out the
rationale from the commit message.

After thinking a bit harder, may I suggest commit message like this (and
please correct me if I'm wrong):

We need to have a dedicated service for xendriverdoamin in driver
domain. This patch creates a service file for it. This service is only
relevant to DomU.

The service file uses ConditionVirtualization=xen becuase that evaluates
to false in Dom0 while true in DomU, so that we only starts this service
in DomU.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel