Re: [Xen-devel] [PATCH v2 1/5] xen/console: consolidate log levels to an array

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.07.16 at 17:13, <wei.liu2@xxxxxxxxxx> wrote:
> --- a/xen/drivers/char/console.c
> +++ b/xen/drivers/char/console.c
> @@ -139,6 +139,20 @@ custom_param("guest_loglvl", parse_guest_loglvl);
>  
>  static atomic_t print_everything = ATOMIC_INIT(0);
>  
> +struct log_level {
> +    const char *str;
> +    unsigned int num;
> +};
> +
> +static struct log_level __initdata log_levels[] = {

const ... __initconstrel

But the question really is, as Ian had already indicated, whether this
can't be solved with less hypervisor changes (in the second patch).
And jftr - I did consider passing strings as part of the hypercall
arguments, but I generally dislike non-human interfaces taking human
readable strings.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel