Re: [Xen-devel] [PATCH] xen-netback: prefer xenbus_scanf() over xenbus_gather()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.07.16 at 11:55, <david.vrabel@xxxxxxxxxx> wrote:
> On 07/07/16 08:57, Jan Beulich wrote:
>> --- 4.7-rc6-prefer-xenbus_scanf.orig/drivers/net/xen-netback/xenbus.c
>> +++ 4.7-rc6-prefer-xenbus_scanf/drivers/net/xen-netback/xenbus.c
>> @@ -842,16 +842,16 @@ static int connect_ctrl_ring(struct back
>>      unsigned int evtchn;
>>      int err;
>>  
>> -    err = xenbus_gather(XBT_NIL, dev->otherend,
>> -                        "ctrl-ring-ref", "%u", &val, NULL);
>> -    if (err)
>> +    err = xenbus_scanf(XBT_NIL, dev->otherend,
>> +                       "ctrl-ring-ref", "%u", &val);
>> +    if (err <= 0)
> 
> < 0

I disagree, as said elsewhere. If you feel like adjusting existing
instances is unnecessary, then drop those patches on the floor.
But I don't like to submit new uses with such a bogus check.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel