Re: [Xen-devel] [PATCH v14 3/3] IOMMU: fix vt-d Device-TLB flush timeout issue

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.07.16 at 11:11, <quan.xu@xxxxxxxxx> wrote:
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -361,6 +361,30 @@ int iommu_iotlb_flush_all(struct domain *d)
>      return rc;
>  }
>  
> +void iommu_dev_iotlb_flush_timeout(struct domain *d,

const

> +                                   struct pci_dev *pdev)
> +{
> +    pcidevs_lock();
> +
> +    ASSERT(pdev->domain);
> +    if ( d != pdev->domain )
> +    {
> +        pcidevs_unlock();
> +        return;
> +    }
> +
> +    list_del(&pdev->domain_list);
> +    pdev->domain = NULL;
> +    pci_hide_existing_device(pdev);
> +    if ( !d->is_shutting_down && printk_ratelimit() )
> +        printk(XENLOG_ERR
> +               "dom%d: ATS device %04x:%02x:%02x.%u flush failed\n",
> +               d->domain_id, pdev->seg, pdev->bus, PCI_SLOT(pdev->devfn),
> +               PCI_FUNC(pdev->devfn));
> +
> +    pcidevs_unlock();
> +}

I'm missing the domain_crash() part here (which would be the only
reason why the parameter above can't be const).

> +static int __must_check dev_invalidate_sync(struct iommu *iommu,
> +                                            struct pci_dev *pdev, u16 did)

const

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel