Re: [Xen-devel] [PATCH] mini-os: replace lib/printf.c with a version not under GPL

[Juergen Gross <jgross@xxxxxxxx>]

On 03/07/16 20:35, Samuel Thibault wrote:
> Hello,
> 
> Juergen Gross, on Fri 01 Jul 2016 11:33:27 +0200, wrote:
>> Instead of a Linux kernel based implementation use one from freeBSD.
> 
> That'd be useful indeed :)
> 
>> I'm not sure about coding style here: should I keep (more or less) the
>> one from freeBSD, or is the Xen style preferred?
> 
> I'd say just keep the file as it is upstream, so we can sync more easily
> in the future.

Okay, thanks.

> 
>> diff --git a/include/lib-gpl.h b/include/lib-gpl.h
>> index d5602b2..7557627 100644
>> --- a/include/lib-gpl.h
>> +++ b/include/lib-gpl.h
> 
> Please move the content to lib.h then, since it won't be gpl any more.

Okay.

> Did you check the boot output e.g. of a trivial mini-os application?
> Notably, iirc there were perhaps odd formating with %x, %p or such.
> Moving to the posix behavior would be a good thing, I'd just want to
> know whether we have some behavior change.

Just double checked: some of the prints are now without leading zeroes:

Without my patch:

Xen Minimal OS!
  start_info: 0000000000074000(VA)
    nr_pages: 0x1000
  shared_inf: 0xd7450000(MA)
     pt_base: 0000000000077000(VA)
nr_pt_frames: 0x5
    mfn_list: 000000000006c000(VA)
   mod_start: 0x0(VA)
     mod_len: 0
       flags: 0x0
    cmd_line:
       stack: 000000000002b540-000000000004b540
MM: Init
      _text: 0000000000000000(VA)
     _etext: 0000000000017708(VA)
   _erodata: 000000000001e000(VA)
     _edata: 000000000001e480(VA)
stack start: 000000000002b540(VA)
       _end: 000000000006ba58(VA)
  start_pfn: 7f
    max_pfn: 1000
Mapping memory range 0x7f000 - 0x1000000
setting 0000000000000000-000000000001e000 readonly
skipped 1000
MM: Initialise page allocator for 85000(85000)-1000000(1000000)
MM: done
Demand map pfns at 1001000-0000002001001000.
Initialising timer interface
Initialising console ... done.
gnttab_table mapped at 0000000001001000.
Initialising scheduler
Thread "Idle": pointer: 0x0000000000090070, stack: 0x00000000000a0000
Thread "xenstore": pointer: 0x00000000000900d0, stack: 0x00000000000b0000
xenbus initialised on irq 1 mfn 0x116675
Thread "shutdown": pointer: 0x0000000000090130, stack: 0x00000000000c0000
kernel.c: dummy main: start_info=000000000004b540

With my patch:

Xen Minimal OS!
  start_info: 0x75000(VA)
    nr_pages: 0x1000
  shared_inf: 0xdb0b0000(MA)
     pt_base: 0x78000(VA)
nr_pt_frames: 0x5
    mfn_list: 0x6d000(VA)
   mod_start: 0x0(VA)
     mod_len: 0
       flags: 0x0
    cmd_line:
       stack: 0x2c580-0x4c580
MM: Init
      _text: 0(VA)
     _etext: 0x183fc(VA)
   _erodata: 0x1f000(VA)
     _edata: 0x1f4c0(VA)
stack start: 0x2c580(VA)
       _end: 0x6ca98(VA)
  start_pfn: 80
    max_pfn: 1000
Mapping memory range 0x80000 - 0x1000000
setting 0-0x1f000 readonly
skipped 1000
MM: Initialise page allocator for 86000(86000)-1000000(1000000)
MM: done
Demand map pfns at 1001000-0x2001001000.
Initialising timer interface
Initialising console ... done.
gnttab_table mapped at 0x1001000.
Initialising scheduler
Thread "Idle": pointer: 0x0x91070, stack: 0x0xa0000
Thread "xenstore": pointer: 0x0x910d0, stack: 0x0xb0000
xenbus initialised on irq 1 mfn 0x11aa76
Thread "shutdown": pointer: 0x0x91130, stack: 0x0xc0000
kernel.c: dummy main: start_info=0x4c580


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel