Re: [Xen-devel] [PATCH v3 1/3] xen: add warning infrastructure

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 23/06/16 12:17, Wei Liu wrote:
> On Thu, Jun 23, 2016 at 11:37:43AM +0100, Wei Liu wrote:
> [...]
>> The warning text (multiple lines) is added as one single string, which
>> means we can't trivially add leading stars at the beginning of each
>> line.
>>
>> I don't feel like arguing over how the text would look like, so if
>> something like:
>>
>>     ************************************************
>>     WARNING 1
>>     ************************************************
>>     WARNING 2
>>     ************************************************
>>     ...
>>     ************************************************
>>     WARNING N
>>     ************************************************
>>
>> is ok to you, I'm fine with using that format, too.
> Here is an example for how it looks like at the moment. Feels OK to me.
>
> (XEN) ***************************************************
> (XEN) WARNING: CONSOLE OUTPUT IS SYNCHRONOUS
> (XEN) This option is intended to aid debugging of Xen by ensuring
> (XEN) that all output is synchronously delivered on the serial line.
> (XEN) However it can introduce SIGNIFICANT latencies and affect
> (XEN) timekeeping. It is NOT recommended for production use!
> (XEN) ***************************************************
> (XEN) WARNING: HVM FORCED EMULATION PREFIX IS AVAILABLE
> (XEN) This option is *ONLY* intended to aid testing of Xen.
> (XEN) It has implications on the security of the system.
> (XEN) Please *DO NOT* use this in production.
> (XEN) ***************************************************

LGTM.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel