Re: [Xen-devel] [PATCH 6/6] xen/build: Use the system stdbool.h header

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.06.16 at 13:24, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/acpi/cpu_idle.c
> +++ b/xen/arch/x86/acpi/cpu_idle.c
> @@ -480,7 +480,7 @@ void trace_exit_reason(u32 *irq_traced)
>   */
>  bool_t errata_c6_eoi_workaround(void)
>  {
> -    static bool_t fix_needed = -1;
> +    static int fix_needed = -1;

int8_t then please.

> --- a/xen/arch/x86/genapic/probe.c
> +++ b/xen/arch/x86/genapic/probe.c
> @@ -56,7 +56,8 @@ custom_param("apic", genapic_apic_force);
>  
>  void __init generic_apic_probe(void) 
>  { 
> -     int i, changed;
> +     bool_t changed;
> +     int i;

You mention it in the description, but I can't see what's wrong with
the current code (and hence I can't conclude what complaint the
compiler has to make).

Also now that you introduce plain bool - why do you use bool_t
here?

> @@ -46,4 +47,8 @@ typedef __u32 __be32;
>  typedef __u64 __le64;
>  typedef __u64 __be64;
>  
> +typedef _Bool bool_t;
> +#define test_and_set_bool(b)   xchg(&(b), 1)
> +#define test_and_clear_bool(b) xchg(&(b), 0)

I guess you then want to use true and false here (which we should
gradually switch to along with the bool_t -> bool transition)?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel