Re: [Xen-devel] [PATCH v2 3/4] xen/init: Move initcall infrastructure into .init.data

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.06.16 at 18:59, <andrew.cooper3@xxxxxxxxxx> wrote:
> Its contents is constant.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Non-ARM part:
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

> @@ -154,14 +160,6 @@ SECTIONS
>         *(.init_array)
>         __ctors_end = .;
>    } :text
> -  . = ALIGN(32);
> -  .initcall.init : {
> -       __initcall_start = .;
> -       *(.initcallpresmp.init)
> -       __presmp_initcall_end = .;
> -       *(.initcall1.init)
> -       __initcall_end = .;
> -  } :text
>    __init_end_efi = .;
>    . = ALIGN(STACK_SIZE);
>    __init_end = .;

For this part, other than the x86 side, I think Konrad has a point: You
change the alignment guarantees for __init_end_efi. Likely that won't
matter, but verifying (and stating so) would still seem necessary /
desirable.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel