Re: [Xen-devel] [PATCH 02/11] hvmctl: convert HVMOP_set_pci_intx_level

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Jun 20, 2016 at 06:53:23AM -0600, Jan Beulich wrote:
> Note that this adds validation of the "domain" interface structure
> field, which previously got ignored.
> 
> Note further that this retains the hvmop interface definitions as those
> had (wrongly) been exposed to non-tool stack consumers (albeit the
> operation wouldn't have succeeded when requested by a domain for
> itself).
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> TBD: xen/xsm/flask/policy/access_vectors says "also needs hvmctl", but
>      I don't see how this has been done so far. With the change here,
>      doing two checks in flask_hvm_control() (the generic one always
>      and a specific one if needed) would of course be simple, but it's
>      unclear how subsequently added sub-ops should then be dealt with
>      (which don't have a similar remark).
> 
> --- a/tools/libxc/xc_misc.c
> +++ b/tools/libxc/xc_misc.c
> @@ -473,30 +473,14 @@ int xc_hvm_set_pci_intx_level(
>      uint8_t domain, uint8_t bus, uint8_t device, uint8_t intx,
>      unsigned int level)
>  {
> -    DECLARE_HYPERCALL_BUFFER(struct xen_hvm_set_pci_intx_level, arg);
> -    int rc;
> +    DECLARE_HVMCTL(set_pci_intx_level, dom,
> +                   .domain = domain,
> +                   .bus    = bus,
> +                   .device = device,
> +                   .intx   = intx,
> +                   .level =  level);

Minor nit: the "=" is not aligned.

For tool and hypervisor code changes, sans the XSM changes:

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel