Re: [Xen-devel] [PATCH 7/7] vm-event/arm: implement support for control-register write vm-events

[Julien Grall <julien.grall.oss@xxxxxxxxx>]

On 16/06/2016 20:24, Corneliu ZUZU wrote:
> On 6/16/2016 5:26 PM, Julien Grall wrote:
> Hi Julien. Yes, I agree that it's complex, I would have preferred to
> split it up too and I actually tried, but the changes are tightly
> coupled and they don't seem to be 'split-able'.
After I reviewed this patch I think it could be simplified a lot.

Most of the registers not trapped by vm-event could be emulated with 
one-line WRITE_SYSREGxx and does not require specific case depending on 
the architecture.
You can give a look how we handle the domain context switch in C 
(arch/arm/domain.c).
Only few of the registers will require more than one-line (such as 
MAIR*, *FAR) which could be over a macro.
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel