Re: [Xen-devel] [PATCH 1/1] tools/livepatch: initialise j to 0 to make some versions of gcc happy

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Jun 15, 2016 at 09:07:53PM +0800, Dongli Zhang wrote:
> Initialise j to 0 to make some versions of gcc (e.g., gcc4.5/4.3) happy to
> avoid compilation error by commit beba3693f7243e68bbe31fe3794da91068eeea5b.
> 

I suggest pasting in Olaf's exact error message here.

To avoid extra round trip, I propose updating the commit message as
followed:

    Initialise j to 0 to make some versions of gcc (e.g., gcc4.5/4.3) happy to
    avoid compilation error by commit beba3693f7243e68bbe31fe3794da91068eeea5b.
    
    Failure manifests with gcc 4.5 as:
    
    [  153s] cc1: warnings being treated as errors
    [  153s] xen-livepatch.c: In function 'main':
    [  153s] xen-livepatch.c:415:12: error: 'j' may be used uninitialized in 
this function
    [  153s] make[3]: *** [xen-livepatch.o] Error 1

If you agree with this I will handle the updating while doing my next
sweep.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel